Naganarasimha G R updated YARN-3044:
    Attachment: YARN-3044-YARN-2928.007.patch

Thanks for the review [~sjlee0],
bq.  but I hope at least we can revisit these names at some point and normalize 
them. Let me know what you think.
Yes definetely from my side as i was little confused when i first saw it 
(configuration to enable ATS1 for application history) but may be we need to 
check with Zhijie for his views as he has coined it :)

bq. This question might be a little beyond the scope of this patch, and I'm 
fine with working on that in a separate JIRA.
Yes this is a good question to track it faster which requires both reader and 
writer changes i think

bq. l.232: Some of the info entries are redundant from the app attempt 
registered event. Are they needed?
checked again with V1 code and its same and the rationale might be that 
original tracking url might change when AM is unregistering and also in case of 
unmanaged AM both URLs are originalTrackingUrl hence during finish it can 
change. apart from these dont see anything repeating.

bq. l.330: Now that this is taken care of by the RM timeline collector manager, 
do we need this method any more? I don't think it is being called.
strange how come checkstyle did not pick this up !

> [Event producers] Implement RM writing app lifecycle events to ATS
> ------------------------------------------------------------------
>                 Key: YARN-3044
>                 URL: https://issues.apache.org/jira/browse/YARN-3044
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>              Labels: BB2015-05-TBR
>         Attachments: YARN-3044-YARN-2928.004.patch, 
> YARN-3044-YARN-2928.005.patch, YARN-3044-YARN-2928.006.patch, 
> YARN-3044-YARN-2928.007.patch, YARN-3044.20150325-1.patch, 
> YARN-3044.20150406-1.patch, YARN-3044.20150416-1.patch
> Per design in YARN-2928, implement RM writing app lifecycle events to ATS.

This message was sent by Atlassian JIRA

Reply via email to