[
https://issues.apache.org/jira/browse/YARN-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Payne updated YARN-1519:
-----------------------------
Attachment: YARN-1519.002.patch
[~hsn], thank you for raising this issue and submitting the patch.
With the recent changes to the Apache build, I'm pretty sure that patches
should take the form of {{YARN-1519.002.patch}}, especially the {{.patch}} so
that it will kick the build.
I have taken the liberty of upmerging the patch and running {{test-patch.sh}}
against it. All is fine except that there are no unit tests. In order to test
this patch effectively, one would have to cause
{{sysconf(_SC_GETPW_R_SIZE_MAX)}} to return -1, and I can't think of a way to
do that without creating a custom {{sysconf()}} object, creating its own share
library, and putting that in LD_LIBRARY_PATH ahead of {{libc}}. Can you think
of a better way to test this? Otherwise, I would suggest to leave the patch as
it is.
+1, by the way (non-binding)
> check if sysconf is implemented before using it
> -----------------------------------------------
>
> Key: YARN-1519
> URL: https://issues.apache.org/jira/browse/YARN-1519
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 3.0.0, 2.3.0
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Labels: BB2015-05-TBR
> Attachments: YARN-1519.002.patch, nodemgr-sysconf.txt
>
>
> If sysconf value _SC_GETPW_R_SIZE_MAX is not implemented, it leads to
> segfault because invalid pointer gets passed to libc function.
> fix: enforce minimum value 1024, same method is used in hadoop-common native
> code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
