[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536587#comment-14536587 ]
Hudson commented on YARN-644: ----------------------------- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #180 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/180/]) YARN-644: Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer (evans: rev bcf2890502fbd11dd394048fe30d67c92aeec4fa) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java * hadoop-yarn-project/CHANGES.txt > Basic null check is not performed on passed in arguments before using them in > ContainerManagerImpl.startContainer > ----------------------------------------------------------------------------------------------------------------- > > Key: YARN-644 > URL: https://issues.apache.org/jira/browse/YARN-644 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager > Affects Versions: 2.7.0 > Reporter: Omkar Vinit Joshi > Assignee: Varun Saxena > Priority: Minor > Fix For: 3.0.0, 2.8.0 > > Attachments: YARN-644.001.patch, YARN-644.002.patch, > YARN-644.03.patch, YARN-644.04.patch, YARN-644.05.patch > > > I see that validation/ null check is not performed on passed in parameters. > Ex. tokenId.getContainerID().getApplicationAttemptId() inside > ContainerManagerImpl.authorizeRequest() > I guess we should add these checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)