[ 
https://issues.apache.org/jira/browse/YARN-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536973#comment-14536973
 ] 

Karthik Kambatla commented on YARN-3259:
----------------------------------------

Thanks for updating the patch, Anubhav.

Few comments:
# Rename {{FSOpDurations#isUpdateThreadRunChanged}} to 
{{FSOpDurations#hasUpdateThreadRunChanged}}
# Test
## Test uses MockClock and hence fails to compile. Can we change that to use 
ControlledClock? 
## Add error messages for all asserts. 
## We should add another case for when there are no node updates. Update should 
be called only after {{updateInterval}}.

> FairScheduler: Update to fairShare could be triggered early on node events 
> instead of waiting for update interval 
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3259
>                 URL: https://issues.apache.org/jira/browse/YARN-3259
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: fairscheduler
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-3259.001.patch, YARN-3259.002.patch
>
>
> Instead of waiting for update interval unconditionally, we can trigger early 
> updates on important events - for eg node join and leave.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to