[
https://issues.apache.org/jira/browse/YARN-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537605#comment-14537605
]
Devaraj K commented on YARN-3513:
---------------------------------
Thanks [~Naganarasimha] for the details. I understand your intention to avoid
the calculations when the log level is not debug. Here we have variables
declared irrespective of the log level and incrementing those variables would
not make a big difference compared to the invalid log. IMO, It would be better
to have the correct details even if it is a single log.
> Remove unused variables in ContainersMonitorImpl and add debug log for
> overall resource usage by all containers
> ----------------------------------------------------------------------------------------------------------------
>
> Key: YARN-3513
> URL: https://issues.apache.org/jira/browse/YARN-3513
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Priority: Trivial
> Labels: BB2015-05-TBR, newbie
> Attachments: YARN-3513.20150421-1.patch, YARN-3513.20150503-1.patch,
> YARN-3513.20150506-1.patch, YARN-3513.20150507-1.patch,
> YARN-3513.20150508-1.patch, YARN-3513.20150508-1.patch
>
>
> Some local variables in MonitoringThread.run() : {{vmemStillInUsage and
> pmemStillInUsage}} are not used and just updated.
> Instead we need to add debug log for overall resource usage by all containers
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
