Zhijie Shen commented on YARN-3044:

bq. Well i had raised config related queries earlier as it dint get concluded 
was planning to get it done as part of a new jira, AFAIK intention in ATS is to 
collect the App side configs than server side ones. And RM will not be aware of 
App configs, so my initial idea was to support additional interface in the 
client to publish Application specific configs. Correct me if i am wrong and 
also inform whether its ok to handle configs in another jira.

So can we undo the code change related to config for this jira?

bq. May be i did not get this clearly, but AFAIK the packages and classes for 
the Timeline events & entities are different and the way we publish entities is 
also different, so though the code looks duplicated i think nutting further to 
be reduced/cleaned up here.

In general, I'm suggesting the code style in MAPREDUCE-6335, which seems to be 
more clear. However, I'm okay to keep to the current code if it's complex to 
refactor it.

bq. but you had commented to have single config 
yarn.system-metrics-publisher.enabled and hence i had remodified.

Right, but it turns out to be that RM and NM seem not to be able to uniform the 
configs (such as the new config added here) between them, and more than one 
feature require somewhat version flag to differentiate the behavior. Never 
mind. I'll take care of it separately.

> [Event producers] Implement RM writing app lifecycle events to ATS
> ------------------------------------------------------------------
>                 Key: YARN-3044
>                 URL: https://issues.apache.org/jira/browse/YARN-3044
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>              Labels: BB2015-05-TBR
>         Attachments: YARN-3044-YARN-2928.004.patch, 
> YARN-3044-YARN-2928.005.patch, YARN-3044-YARN-2928.006.patch, 
> YARN-3044-YARN-2928.007.patch, YARN-3044.20150325-1.patch, 
> YARN-3044.20150406-1.patch, YARN-3044.20150416-1.patch
> Per design in YARN-2928, implement RM writing app lifecycle events to ATS.

This message was sent by Atlassian JIRA

Reply via email to