[jira] [Commented] (YARN-2336) Fair scheduler REST api returns a missing '[' bracket JSON for deep queue tree

[Tsuyoshi Ozawa (JIRA)]

    [ 
https://issues.apache.org/jira/browse/YARN-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541531#comment-14541531
 ] 

Tsuyoshi Ozawa commented on YARN-2336:
--------------------------------------

[~ajisakaa] thank you for clarification. It makes sense to me.

I have a comment about return value. I think childQueue should be array instead 
of map without key, "queue" since the key looks redundant. What do you think?
{quote}
+                            "childQueues": {
+                                "queue": [
+                                    {
{quote}

A following data structure looks more straight forward to me:
{quote}
childQueues(array)
 |---- childQueues(array)
          |---- childQueues
 |---- childQueues(array
{quote}

I meant that the test code should be as follows in this case, for example:
{code}
    JSONArray subQueueInfo = json.getJSONObject("scheduler")
        .getJSONObject("schedulerInfo").getJSONObject("rootQueue")
        .getJSONArray("childQueues").getJSONObject(1)
        .getJSONArray("childQueues");
    // subQueueInfo is consist of subqueue1 and subqueue2 info
    assertEquals(2, subQueueInfo.length());
{code}

> Fair scheduler REST api returns a missing '[' bracket JSON for deep queue tree
> ------------------------------------------------------------------------------
>
>                 Key: YARN-2336
>                 URL: https://issues.apache.org/jira/browse/YARN-2336
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 2.4.1
>            Reporter: Kenji Kikushima
>            Assignee: Kenji Kikushima
>              Labels: BB2015-05-RFC
>         Attachments: YARN-2336-2.patch, YARN-2336-3.patch, YARN-2336-4.patch, 
> YARN-2336.005.patch, YARN-2336.patch
>
>
> When we have sub queues in Fair Scheduler, REST api returns a missing '[' 
> blacket JSON for childQueues.
> This issue found by [~ajisakaa] at YARN-1050.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)