Sangjin Lee commented on YARN-3411:

Vrushali and I spoke offline on the findbugs issues and others. Here is some 
more feedback on the existing patch.

I would try to limit the public surface area as good hygiene (making classes 
non-public by default unless/until necessary). It applies to 
EntityColumnDetails, EntityTableDetails, and Range.

- l.142: let's declare value inside the loop as well
- l.200: Object value => String value?
- l.228: let's declare key inside the loop
- l.267: let's declare id inside the outer for loop
- l.272: let's declare key inside the inner for loop

- l.21-22: both can/should be final

- let's add Private and Unstable annotations

> [Storage implementation] explore the native HBase write schema for storage
> --------------------------------------------------------------------------
>                 Key: YARN-3411
>                 URL: https://issues.apache.org/jira/browse/YARN-3411
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Vrushali C
>            Priority: Critical
>         Attachments: ATSv2BackendHBaseSchemaproposal.pdf, 
> YARN-3411-YARN-2928.001.patch, YARN-3411.poc.2.txt, YARN-3411.poc.3.txt, 
> YARN-3411.poc.4.txt, YARN-3411.poc.5.txt, YARN-3411.poc.6.txt, 
> YARN-3411.poc.7.txt, YARN-3411.poc.txt
> There is work that's in progress to implement the storage based on a Phoenix 
> schema (YARN-3134).
> In parallel, we would like to explore an implementation based on a native 
> HBase schema for the write path. Such a schema does not exclude using 
> Phoenix, especially for reads and offline queries.
> Once we have basic implementations of both options, we could evaluate them in 
> terms of performance, scalability, usability, etc. and make a call.

This message was sent by Atlassian JIRA

Reply via email to