[ 
https://issues.apache.org/jira/browse/YARN-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544771#comment-14544771
 ] 

Xuan Gong commented on YARN-3505:
---------------------------------

reopen the ticket and attached an addendum patch...

{code}
      if (appFinished) {
        // If the app is finished, one extra final report with log aggregation
        // status SUCCEEDED/FAILED will be sent to RM to inform the RM
        // that the log aggregation in this NM is completed.
        LogAggregationReport finalReport =
            Records.newRecord(LogAggregationReport.class);
        finalReport.setApplicationId(appId);
        finalReport.setLogAggregationStatus(renameTemporaryLogFileFailed
            ? LogAggregationStatus.FAILED : LogAggregationStatus.SUCCEEDED);
        this.context.getLogAggregationStatusForApps().add(report);
      }
{code}

Should attach the finalReport ...
{code}
this.context.getLogAggregationStatusForApps().add(finalReport);
{code}

> Node's Log Aggregation Report with SUCCEED should not cached in RMApps
> ----------------------------------------------------------------------
>
>                 Key: YARN-3505
>                 URL: https://issues.apache.org/jira/browse/YARN-3505
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: log-aggregation
>    Affects Versions: 2.8.0
>            Reporter: Junping Du
>            Assignee: Xuan Gong
>            Priority: Critical
>             Fix For: 2.8.0
>
>         Attachments: YARN-3505.1.patch, YARN-3505.2.patch, 
> YARN-3505.2.rebase.patch, YARN-3505.3.patch, YARN-3505.4.patch, 
> YARN-3505.5.patch, YARN-3505.6.patch, YARN-3505.addendum.patch
>
>
> Per discussions in YARN-1402, we shouldn't cache all node's log aggregation 
> reports in RMApps for always, especially for those finished with SUCCEED.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to