[
https://issues.apache.org/jira/browse/YARN-3543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546560#comment-14546560
]
Rohith commented on YARN-3543:
------------------------------
bq. ApplicationReport.newInstance() is Private, so you should simply update the
existing method instead of adding a new one.
I understood your comment above like since it is private, newInstance() method
should not be modified. So I just added setter and getter methods in
ApplicationReport. But doesn't impact compatibility?
bq. app == null ? null : app.getUser()); What are these changes for?
This is for fixing findbug in earlier jenkins report. One thing observed is
# when {{return ApplicationReport.newInstance}}, does not give findbug warning
but
# when assign {{ApplicationReport.newInstance}} to new variable and return the
variable giving findbug waining. So I changed above null check.
bq. AppInfo.getUnmanagedAM() needs to be renamed too.
Agree
> ApplicationReport should be able to tell whether the Application is AM
> managed or not.
> ---------------------------------------------------------------------------------------
>
> Key: YARN-3543
> URL: https://issues.apache.org/jira/browse/YARN-3543
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: api
> Affects Versions: 2.6.0
> Reporter: Spandan Dutta
> Assignee: Rohith
> Labels: BB2015-05-TBR
> Attachments: 0001-YARN-3543.patch, 0001-YARN-3543.patch,
> 0002-YARN-3543.patch, 0002-YARN-3543.patch, 0003-YARN-3543.patch,
> 0003-YARN-3543.patch, YARN-3543-AH.PNG, YARN-3543-RM.PNG
>
>
> Currently we can know whether the application submitted by the user is AM
> managed from the applicationSubmissionContext. This can be only done at the
> time when the user submits the job. We should have access to this info from
> the ApplicationReport as well so that we can check whether an app is AM
> managed or not anytime.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
