Vinod Kumar Vavilapalli commented on YARN-2729:

bq. I think the format expected from the command should be more structured. 
Specifically as we expect more per-label attributes in line with YARN-3565.
bq. So IMHO if there is plan to make this interface public & stable then would 
be better do these changes now itself if not it would better done after 
requirement for constraint labels, so that more clarity on structure would be 
there? Tan, Wangda and you can share your opinion on this, based on it will do 
the modifications.
I think once we start marking this script-based provider feature as public, the 
expected output from the script will automatically become a public interface 
unless we explicitly say no. We should start thinking about this now to avoid 
uncertainty in the future?

bq. These needs to be done irrespective of the label provider (system or 
user's) hence kept it in NodeStatusUpdaterImpl , but if req to be moved out 
then we need to bring in some intermediate manager(/helper/delegator) class 
between NodeStatusUpdaterImpl and NodeLabelsProvider.
Isn't AbstractNodeLabelsProvider a good place to do these steps?

> Support script based NodeLabelsProvider Interface in Distributed Node Label 
> Configuration Setup
> -----------------------------------------------------------------------------------------------
>                 Key: YARN-2729
>                 URL: https://issues.apache.org/jira/browse/YARN-2729
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: YARN-2729.20141023-1.patch, YARN-2729.20141024-1.patch, 
> YARN-2729.20141031-1.patch, YARN-2729.20141120-1.patch, 
> YARN-2729.20141210-1.patch, YARN-2729.20150309-1.patch, 
> YARN-2729.20150322-1.patch, YARN-2729.20150401-1.patch, 
> YARN-2729.20150402-1.patch, YARN-2729.20150404-1.patch, 
> YARN-2729.20150517-1.patch
> Support script based NodeLabelsProvider Interface in Distributed Node Label 
> Configuration Setup . 

This message was sent by Atlassian JIRA

Reply via email to