[ 
https://issues.apache.org/jira/browse/YARN-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549378#comment-14549378
 ] 

Wangda Tan commented on YARN-3647:
----------------------------------

[~sunilg], thanks for working on this:

1) getLabelsInfoOnNode in RMNodeLabelsManager is not needed actually, you can 
use CommonNodeLabelsManager.getLabelsByNode instead. Make it public and add 
readlock should be enough, right?

2) Tests of RMWebServices: I suggest to add tests to make sure all getters with 
NodeLabel has proper exclusive from NodeLabelsManager to avoid future 
regression.
You can set different label properties like x.exclusive=true y.exclusive=false 
and check it in test.

> RMWebServices api's should use updated api from CommonNodeLabelsManager to 
> get NodeLabel object
> -----------------------------------------------------------------------------------------------
>
>                 Key: YARN-3647
>                 URL: https://issues.apache.org/jira/browse/YARN-3647
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.6.0
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-3647.patch
>
>
> After YARN-3579, RMWebServices apis can use the updated version of apis in 
> CommonNodeLabelsManager which gives full NodeLabel object instead of creating 
> NodeLabel object from plain label name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to