[ https://issues.apache.org/jira/browse/YARN-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551467#comment-14551467 ]
Hadoop QA commented on YARN-3677: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | patch | 0m 1s | The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. | | {color:blue}0{color} | pre-patch | 14m 35s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | | {color:green}+1{color} | javac | 7m 32s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 33s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 0m 25s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 34s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 15s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | yarn tests | 50m 3s | Tests passed in hadoop-yarn-server-resourcemanager. | | | | 85m 55s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12733965/YARN-3677-20150519.txt | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 7438966 | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8011/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8011/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8011/console | This message was automatically generated. > Fix findbugs warnings in yarn-server-resourcemanager > ---------------------------------------------------- > > Key: YARN-3677 > URL: https://issues.apache.org/jira/browse/YARN-3677 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Reporter: Akira AJISAKA > Assignee: Vinod Kumar Vavilapalli > Priority: Minor > Labels: newbie > Attachments: YARN-3677-20150519.txt > > > There is 1 findbugs warning in FileSystemRMStateStore.java. > {noformat} > Inconsistent synchronization of FileSystemRMStateStore.isHDFS; locked 66% of > time > Unsynchronized access at FileSystemRMStateStore.java: [line 156] > Field > org.apache.hadoop.yarn.server.resourcemanager.recovery.FileSystemRMStateStore.isHDFS > Synchronized 66% of the time > Synchronized access at FileSystemRMStateStore.java: [line 148] > Synchronized access at FileSystemRMStateStore.java: [line 859] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)