[ https://issues.apache.org/jira/browse/YARN-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553364#comment-14553364 ]
Hadoop QA commented on YARN-3051: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 14m 55s | Pre-patch YARN-2928 compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 3 new or modified test files. | | {color:green}+1{color} | javac | 7m 42s | There were no new javac warning messages. | | {color:red}-1{color} | javadoc | 9m 39s | The applied patch generated 6 additional warning messages. | | {color:red}-1{color} | release audit | 0m 19s | The applied patch generated 2 release audit warnings. | | {color:red}-1{color} | checkstyle | 1m 19s | The applied patch generated 23 new checkstyle issues (total was 234, now 257). | | {color:green}+1{color} | shellcheck | 0m 6s | There were no new shellcheck (v0.3.3) issues. | | {color:red}-1{color} | whitespace | 0m 1s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 40s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 41s | The patch built with eclipse:eclipse. | | {color:red}-1{color} | findbugs | 3m 36s | The patch appears to introduce 6 new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | yarn tests | 0m 25s | Tests passed in hadoop-yarn-api. | | {color:green}+1{color} | yarn tests | 1m 56s | Tests passed in hadoop-yarn-common. | | {color:green}+1{color} | yarn tests | 1m 3s | Tests passed in hadoop-yarn-server-timelineservice. | | | | 43m 47s | | \\ \\ || Reason || Tests || | FindBugs | module:hadoop-yarn-server-timelineservice | | | Found reliance on default encoding in org.apache.hadoop.yarn.server.timelineservice.storage.FileSystemTimelineReaderImpl.getEntities(String, String, String, Long, Long, Long, String, Long, Collection, Collection, Collection, Collection, Collection, EnumSet):in org.apache.hadoop.yarn.server.timelineservice.storage.FileSystemTimelineReaderImpl.getEntities(String, String, String, Long, Long, Long, String, Long, Collection, Collection, Collection, Collection, Collection, EnumSet): new java.io.FileReader(File) At FileSystemTimelineReaderImpl.java:[line 88] | | | Found reliance on default encoding in org.apache.hadoop.yarn.server.timelineservice.storage.FileSystemTimelineReaderImpl.getEntity(String, String, String, String, Collection, Collection, Long, Long, EnumSet):in org.apache.hadoop.yarn.server.timelineservice.storage.FileSystemTimelineReaderImpl.getEntity(String, String, String, String, Collection, Collection, Long, Long, EnumSet): new java.io.FileReader(File) At FileSystemTimelineReaderImpl.java:[line 68] | | FindBugs | module:hadoop-yarn-common | | | Inconsistent synchronization of org.apache.hadoop.yarn.api.protocolrecords.impl.pb.AllocateResponsePBImpl.builder; locked 92% of time Unsynchronized access at AllocateResponsePBImpl.java:92% of time Unsynchronized access at AllocateResponsePBImpl.java:[line 391] | | | Inconsistent synchronization of org.apache.hadoop.yarn.api.protocolrecords.impl.pb.AllocateResponsePBImpl.proto; locked 94% of time Unsynchronized access at AllocateResponsePBImpl.java:94% of time Unsynchronized access at AllocateResponsePBImpl.java:[line 391] | | | Inconsistent synchronization of org.apache.hadoop.yarn.api.protocolrecords.impl.pb.AllocateResponsePBImpl.viaProto; locked 94% of time Unsynchronized access at AllocateResponsePBImpl.java:94% of time Unsynchronized access at AllocateResponsePBImpl.java:[line 391] | | FindBugs | module:hadoop-yarn-api | | | org.apache.hadoop.yarn.api.records.timelineservice.TimelineMetric$1.compare(Long, Long) negates the return value of Long.compareTo(Long) At TimelineMetric.java:value of Long.compareTo(Long) At TimelineMetric.java:[line 47] | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12734255/YARN-3051-YARN-2928.03.patch | | Optional Tests | shellcheck javadoc javac unit findbugs checkstyle | | git revision | YARN-2928 / 463e070 | | javadoc | https://builds.apache.org/job/PreCommit-YARN-Build/8034/artifact/patchprocess/diffJavadocWarnings.txt | | Release Audit | https://builds.apache.org/job/PreCommit-YARN-Build/8034/artifact/patchprocess/patchReleaseAuditProblems.txt | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/8034/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt | | whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/8034/artifact/patchprocess/whitespace.txt | | Findbugs warnings | https://builds.apache.org/job/PreCommit-YARN-Build/8034/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-timelineservice.html | | Findbugs warnings | https://builds.apache.org/job/PreCommit-YARN-Build/8034/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html | | Findbugs warnings | https://builds.apache.org/job/PreCommit-YARN-Build/8034/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-api.html | | hadoop-yarn-api test log | https://builds.apache.org/job/PreCommit-YARN-Build/8034/artifact/patchprocess/testrun_hadoop-yarn-api.txt | | hadoop-yarn-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/8034/artifact/patchprocess/testrun_hadoop-yarn-common.txt | | hadoop-yarn-server-timelineservice test log | https://builds.apache.org/job/PreCommit-YARN-Build/8034/artifact/patchprocess/testrun_hadoop-yarn-server-timelineservice.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8034/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8034/console | This message was automatically generated. > [Storage abstraction] Create backing storage read interface for ATS readers > --------------------------------------------------------------------------- > > Key: YARN-3051 > URL: https://issues.apache.org/jira/browse/YARN-3051 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Affects Versions: YARN-2928 > Reporter: Sangjin Lee > Assignee: Varun Saxena > Attachments: YARN-3051-YARN-2928.03.patch, > YARN-3051.wip.02.YARN-2928.patch, YARN-3051.wip.patch, YARN-3051_temp.patch > > > Per design in YARN-2928, create backing storage read interface that can be > implemented by multiple backing storage implementations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)