Junping Du commented on YARN-3695:

bq. Junping Du, we have seen in some cases EOFException is thrown when 
connection loses. see YARN-2841
I see. Thanks [~jianhe] for sharing the background here. Now I agree 
EOFException shouldn't be a problem for retry. 

bq. Seems I forgot to fix retry policy FOREVER in ServerProxy as part of 
No problem. We can fix the same issue in this JIRA given EOFException deserve a 
retry also. I will update JIRA name to reflect this. Please feel free to take 
this JIRA if you want to work on it. Thx!

> EOFException shouldn't be retry forever in RMProxy
> --------------------------------------------------
>                 Key: YARN-3695
>                 URL: https://issues.apache.org/jira/browse/YARN-3695
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Junping Du
> YARN-3646 fix the retry forever policy that it only applies on limited 
> exceptions rather than all exceptions. Here, we may want to review these 
> exceptions. At least, exception EOFException shouldn't retry forever.
> {code}
>     exceptionToPolicyMap.put(EOFException.class, retryPolicy);
>     exceptionToPolicyMap.put(ConnectException.class, retryPolicy);
>     exceptionToPolicyMap.put(NoRouteToHostException.class, retryPolicy);
>     exceptionToPolicyMap.put(UnknownHostException.class, retryPolicy);
>     exceptionToPolicyMap.put(ConnectTimeoutException.class, retryPolicy);
>     exceptionToPolicyMap.put(RetriableException.class, retryPolicy);
>     exceptionToPolicyMap.put(SocketException.class, retryPolicy);
> {code}

This message was sent by Atlassian JIRA

Reply via email to