[ 
https://issues.apache.org/jira/browse/YARN-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556308#comment-14556308
 ] 

Joep Rottinghuis commented on YARN-3706:
----------------------------------------

I've noticed that in 
o.a.h.y.s.t.s.EntityInfoColumnDetails.storeWithColumnPrefix we use 
TimelineEntitySchemaConstants.ROW_KEY_SEPARATOR to separate the fields in 
TimelineEntity.getRelatesToEntities()
If any of those related entities contain a ROW_KEY_SEPARATOR (currently "!") 
then we'll have a problem parsing these entries correctly when reading them out.
I'll try to address that in the patch suggestion.

> Generalize native HBase writer for additional tables
> ----------------------------------------------------
>
>                 Key: YARN-3706
>                 URL: https://issues.apache.org/jira/browse/YARN-3706
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Joep Rottinghuis
>            Priority: Minor
>
> When reviewing YARN-3411 we noticed that we could change the class hierarchy 
> a little in order to accommodate additional tables easily.
> In order to get ready for benchmark testing we left the original layout in 
> place, as performance would not be impacted by the code hierarchy.
> Here is a separate jira to address the hierarchy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to