Wangda Tan commented on YARN-3632:

Some comments:
1) In CS, now it updates resource when ask.isEmpty(). But actually demand will 
be only updated when AppSchedulingInfo.updateResourceRequests when 
updatePendingResource is true. I think you can modify interface of 
updateResourceRequests to return updatePendingResource. 

2) About locking, I noticed when application doing allocation, it locks 
LeafQueue. I think we'd better not doing that. Synchronized lock of 
LeafQueue.getOrderingPolicy is not necessary and you can only lock 
entitiesToReorder instead of whole object.

3) nits:
- preIterate -> reorderScheduleEntities, to clearly show what it's doing for 

> Ordering policy should be allowed to reorder an application when demand 
> changes
> -------------------------------------------------------------------------------
>                 Key: YARN-3632
>                 URL: https://issues.apache.org/jira/browse/YARN-3632
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>            Reporter: Craig Welch
>            Assignee: Craig Welch
>         Attachments: YARN-3632.0.patch, YARN-3632.1.patch, YARN-3632.3.patch, 
> YARN-3632.4.patch, YARN-3632.5.patch, YARN-3632.6.patch
> At present, ordering policies have the option to have an application 
> re-ordered (for allocation and preemption) when it is allocated to or a 
> container is recovered from the application.  Some ordering policies may also 
> need to reorder when demand changes if that is part of the ordering 
> comparison, this needs to be made available (and used by the 
> fairorderingpolicy when sizebasedweight is true)

This message was sent by Atlassian JIRA

Reply via email to