Wangda Tan commented on YARN-3686:

[~sunilg], thanks for updating:
Mostly looks good, I still suggest to add one more test which I mentioned above
bq. 2. spaces in queue configuration (default-node-label-expression) will be 
Which should be: queue default-node-label-expression from 
CapacitySchedulerConfiguration contains spaces, and after queue initialized, 
getDefaultNodeLabelExpression of queue should be trimmed.

> CapacityScheduler should trim default_node_label_expression
> -----------------------------------------------------------
>                 Key: YARN-3686
>                 URL: https://issues.apache.org/jira/browse/YARN-3686
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Sunil G
>            Priority: Critical
>         Attachments: 0001-YARN-3686.patch, 0002-YARN-3686.patch, 
> 0003-YARN-3686.patch
> We should trim default_node_label_expression for queue before using it.

This message was sent by Atlassian JIRA

Reply via email to