[ https://issues.apache.org/jira/browse/YARN-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558815#comment-14558815 ]
Hadoop QA commented on YARN-3712: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 14m 35s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | | {color:green}+1{color} | javac | 7m 35s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 34s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 0m 36s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 33s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 2s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | yarn tests | 6m 5s | Tests passed in hadoop-yarn-server-nodemanager. | | | | 41m 58s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12735262/YARN-3712.02.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 39077db | | hadoop-yarn-server-nodemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8079/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8079/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8079/console | This message was automatically generated. > ContainersLauncher: handle event CLEANUP_CONTAINER asynchronously > ----------------------------------------------------------------- > > Key: YARN-3712 > URL: https://issues.apache.org/jira/browse/YARN-3712 > Project: Hadoop YARN > Issue Type: Improvement > Components: nodemanager > Reporter: Jun Gong > Assignee: Jun Gong > Attachments: YARN-3712.01.patch, YARN-3712.02.patch > > > It will save some time by handling event CLEANUP_CONTAINER asynchronously. > This improvement will be useful for cases that cleaning up container cost a > little long time(e.g. for our case: we are running Docker container on NM, it > will take above 1 seconds to clean up one docker container. ) and many > containers to clean up(e.g. NM need clean up all running containers when NM > shutdown). -- This message was sent by Atlassian JIRA (v6.3.4#6332)