[
https://issues.apache.org/jira/browse/YARN-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560116#comment-14560116
]
Hadoop QA commented on YARN-3682:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | patch | 0m 1s | The patch file was not named
according to hadoop's naming conventions. Please see
https://wiki.apache.org/hadoop/HowToContribute for instructions. |
| {color:blue}0{color} | pre-patch | 14m 36s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 3 new or modified test files. |
| {color:red}-1{color} | javac | 2m 54s | The patch appears to cause the
build to fail. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12735438/YARN-3682-20150526.txt
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / cdbd66b |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8091/console |
This message was automatically generated.
> Decouple PID-file management from ContainerExecutor
> ---------------------------------------------------
>
> Key: YARN-3682
> URL: https://issues.apache.org/jira/browse/YARN-3682
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Vinod Kumar Vavilapalli
> Attachments: YARN-3682-20150526.txt
>
>
> The PID-files management currently present in ContainerExecutor really
> doesn't belong there. I know the original history of why we added it, that
> was about the only right place to put it in at that point of time.
> Given the evolution of executors for Windows etc, the ContainerExecutor is
> getting more complicated than is necessary.
> We should pull the PID-file management into its own entity.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
