Sangjin Lee commented on YARN-2556:

[~lichangleo], thanks much for the latest patch! I feel that it's real close. I 
like that it's much more modular and can support v2 more easily. I do have a 
few more comments and suggestions.

- l.35-36: there should be no timeline type imports here; unused imports?
- l.201-212: it's an oversight, but this belongs in the SimpleEntityWriter 
class, and should be moved there

- Can you refactor this as much as possible so that v1 and v2 do not duplicate 
any shared code? For example, JobFiles, constants, and some operations inside 
map() are clearly common between v1 and v2. It might involve extracting some 
common (helper) methods.
- l.162: We found this with the v2 code, but there is a bug here: it is 
possible that the JobFiles instance may not have both the jobhistory file and 
the configuration file. We should skip processing the JobFiles instance if 
either is null.

> Tool to measure the performance of the timeline server
> ------------------------------------------------------
>                 Key: YARN-2556
>                 URL: https://issues.apache.org/jira/browse/YARN-2556
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Jonathan Eagles
>            Assignee: Chang Li
>              Labels: BB2015-05-TBR
>         Attachments: YARN-2556-WIP.patch, YARN-2556-WIP.patch, 
> YARN-2556.1.patch, YARN-2556.10.patch, YARN-2556.11.patch, YARN-2556.2.patch, 
> YARN-2556.3.patch, YARN-2556.4.patch, YARN-2556.5.patch, YARN-2556.6.patch, 
> YARN-2556.7.patch, YARN-2556.8.patch, YARN-2556.9.patch, YARN-2556.patch, 
> yarn2556.patch, yarn2556.patch, yarn2556_wip.patch
> We need to be able to understand the capacity model for the timeline server 
> to give users the tools they need to deploy a timeline server with the 
> correct capacity.
> I propose we create a mapreduce job that can measure timeline server write 
> and read performance. Transactions per second, I/O for both read and write 
> would be a good start.
> This could be done as an example or test job that could be tied into gridmix.

This message was sent by Atlassian JIRA

Reply via email to