[
https://issues.apache.org/jira/browse/YARN-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564128#comment-14564128
]
Karthik Kambatla commented on YARN-3547:
----------------------------------------
Per recent discussion, let us go with the approach in YARN-3547.004.patch?
Review comments for 004 patch:
# What is the readLock protecting? If it is only runnableApps, we should
release the lock as soon as we are done iterating through runnableApps.
# Use {{(!pending.equals(Resources.none())}} instead of an elaborate check?
# We can avoid importing {{Set}} by just using {{TreeSet}}. Since it is all
local, that should be fine.
> FairScheduler: Apps that have no resource demand should not participate
> scheduling
> ----------------------------------------------------------------------------------
>
> Key: YARN-3547
> URL: https://issues.apache.org/jira/browse/YARN-3547
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Reporter: Xianyin Xin
> Assignee: Xianyin Xin
> Attachments: YARN-3547.001.patch, YARN-3547.002.patch,
> YARN-3547.003.patch, YARN-3547.004.patch, YARN-3547.005.patch
>
>
> At present, all of the 'running' apps participate the scheduling process,
> however, most of them may have no resource demand on a production cluster, as
> the app's status is running other than waiting for resource at the most of
> the app's lifetime. It's not a wise way we sort all the 'running' apps and
> try to fulfill them, especially on a large-scale cluster which has heavy
> scheduling load.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
