Karthik Kambatla commented on YARN-3534:

Thanks for working on this, Inigo.

Few comments:
# Given these stats are to be sent to the RM in heartbeat, should we capture 
the aggregate node resource usage in {{ResourceUtilization}}? 
# Instead of adding a separate {{DEFAULT_NM_NODE_MON_INTERVAL_MS}}, we should 
probably just re-use the default for container-monitor?
# Also, should we add another config 
{{yarn.nodemanager.usage-monitor.interval-ms}} that both container-monitor and 
node-monitor inherit unless specified otherwise? If that seems reasonable, we 
should deprecate the default value for container-monitor-interval.
# For the monitoring thread,
## set the thread name?
## make it a daemon thread?
## on {{monitoringThread.join()}}, specify a timeout as well. 
## in the corresponding catch-block, at least log that we couldn't wait until 
the monitoring-thread is interrupted.

> Collect memory/cpu usage on the node
> ------------------------------------
>                 Key: YARN-3534
>                 URL: https://issues.apache.org/jira/browse/YARN-3534
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>    Affects Versions: 2.7.0
>            Reporter: Inigo Goiri
>            Assignee: Inigo Goiri
>         Attachments: YARN-3534-1.patch, YARN-3534-2.patch, YARN-3534-3.patch, 
> YARN-3534-3.patch, YARN-3534-4.patch, YARN-3534-5.patch, YARN-3534-6.patch, 
> YARN-3534-7.patch, YARN-3534-8.patch, YARN-3534-9.patch
>   Original Estimate: 336h
>  Remaining Estimate: 336h
> YARN should be aware of the resource utilization of the nodes when scheduling 
> containers. For this, this task will implement the collection of memory/cpu 
> usage on the node.

This message was sent by Atlassian JIRA

Reply via email to