Junping Du commented on YARN-41:

Thanks [~devaraj.k] for updating the patch with addressing previous comments! 
Latest patch LGTM. +1. Will commit it tomorrow if no further comments on the 
code from other reviewers.
In addition, given the patch involve new SHUTDOWN category on: NodeState, UI 
and Cluster Metrics. Although it doesn't break any public APIs, we should mark 
this JIRA as incompatible for its inconsistent behaviors with previous releases 
in UI, CLI, Metrics (to notify users or third-party management & monitor 
software). In general, I think it should be fine to keep the plan to include 
this patch in 2.x releases. However, please comments here to let us know if you 
have any concerns.

> The RM should handle the graceful shutdown of the NM.
> -----------------------------------------------------
>                 Key: YARN-41
>                 URL: https://issues.apache.org/jira/browse/YARN-41
>             Project: Hadoop YARN
>          Issue Type: New Feature
>          Components: nodemanager, resourcemanager
>            Reporter: Ravi Teja Ch N V
>            Assignee: Devaraj K
>         Attachments: MAPREDUCE-3494.1.patch, MAPREDUCE-3494.2.patch, 
> MAPREDUCE-3494.patch, YARN-41-1.patch, YARN-41-2.patch, YARN-41-3.patch, 
> YARN-41-4.patch, YARN-41-5.patch, YARN-41-6.patch, YARN-41-7.patch, 
> YARN-41-8.patch, YARN-41.patch
> Instead of waiting for the NM expiry, RM should remove and handle the NM, 
> which is shutdown gracefully.

This message was sent by Atlassian JIRA

Reply via email to