[
https://issues.apache.org/jira/browse/YARN-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohith updated YARN-3733:
-------------------------
Attachment: 0002-YARN-3733.patch
Thanks [~sunilg] and [~leftnoteasy] for sharing your thoughts..
I modified bit of logic and the order of if check so that it should handle all
the possible combination of inputs below table. The problem was in 5th and 7th
inputs. The validation returning 1 but it was expected to be zero for 5th
combinations i.e flow never reach 2nd check since 1st step is OR for memory vs
cpu.
||Sl.no||cr||lhs||rhs||Output||
|1|<0,0>| <1,1> | <1,1> | 0 |
|2|<0,0>| <1,1> | <0,0> | 1 |
|3|<0,0>| <0,0> | <1,1> | -1 |
|4|<0,0>| <0,1> | <1,0> | 0 |
|5|<0,0>| <1,0> | <0,1> | 0 |
|6|<0,0>| <1,1> | <1,0> | 1 |
|7|<0,0>| <1,0> | <1,1> | -1 |
Updated Patch has followig change :
# Changed the logic for comparing lhs and rhs resources when clusterResource is
empty as suggested.
# Added test for AMLimit usage.
# Addred test for all above cobination of inputs.
Kindly review the patch
> DominantRC#compare() does not work as expected if cluster resource is empty
> ---------------------------------------------------------------------------
>
> Key: YARN-3733
> URL: https://issues.apache.org/jira/browse/YARN-3733
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 2.7.0
> Environment: Suse 11 Sp3 , 2 NM , 2 RM
> one NM - 3 GB 6 v core
> Reporter: Bibin A Chundatt
> Assignee: Rohith
> Priority: Blocker
> Attachments: 0001-YARN-3733.patch, 0002-YARN-3733.patch,
> YARN-3733.patch
>
>
> Steps to reproduce
> =================
> 1. Install HA with 2 RM 2 NM (3072 MB * 2 total cluster)
> 2. Configure map and reduce size to 512 MB after changing scheduler minimum
> size to 512 MB
> 3. Configure capacity scheduler and AM limit to .5
> (DominantResourceCalculator is configured)
> 4. Submit 30 concurrent task
> 5. Switch RM
> Actual
> =====
> For 12 Jobs AM gets allocated and all 12 starts running
> No other Yarn child is initiated , *all 12 Jobs in Running state for ever*
> Expected
> =======
> Only 6 should be running at a time since max AM allocated is .5 (3072 MB)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
