[ https://issues.apache.org/jira/browse/YARN-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14571610#comment-14571610 ]
Li Lu commented on YARN-3276: ----------------------------- The -1 appears to be irrelevant to the fix in this patch. I can confirm we actually have one findbugs warning in TimelineMetric, reverse comparator. Will open a separate JIRA to do a quick fix. > Refactor and fix null casting in some map cast for TimelineEntity (old and > new) and fix findbug warnings > -------------------------------------------------------------------------------------------------------- > > Key: YARN-3276 > URL: https://issues.apache.org/jira/browse/YARN-3276 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Reporter: Junping Du > Assignee: Junping Du > Attachments: YARN-3276-YARN-2928.v3.patch, > YARN-3276-YARN-2928.v4.patch, YARN-3276-YARN-2928.v5-fix-checkstyle.patch, > YARN-3276-YARN-2928.v5.patch, YARN-3276-YARN-2928.v6.patch, > YARN-3276-v2.patch, YARN-3276-v3.patch, YARN-3276.patch > > > Per discussion in YARN-3087, we need to refactor some similar logic to cast > map to hashmap and get rid of NPE issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)