[ 
https://issues.apache.org/jira/browse/YARN-3787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577624#comment-14577624
 ] 

Zhijie Shen commented on YARN-3787:
-----------------------------------

The patch looks good to me overall. Some comments: 

1. "startedTimeBegin" -> "app.started-time.begin" and "startedTimeEnd" -> 
"app.started-time.end"?
{code}
36        String APP_START_TIME_BEGIN = "startedTimeBegin";
37        String APP_START_TIME_END = "startedTimeEnd";
{code}

2. This semantics enforced for appblocks is conflicting with webservices.
{code}
103         if (appStartedTimeBegain > appStartedTimeEnd) {
104           throw new BadRequestException(
105             "startedTimeEnd must be greater than startTimeBegin");
106         }
{code}

> loading applications by filtering appstartedTime period for ATS Web UI
> ----------------------------------------------------------------------
>
>                 Key: YARN-3787
>                 URL: https://issues.apache.org/jira/browse/YARN-3787
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager, webapp, yarn
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-3787.1.patch
>
>
> After YARN-3700, we have defined a parameter called apps.num for loading a 
> given number of applications in ats web page.
> We could also define several additional parameters for the similar purpose. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to