[ 
https://issues.apache.org/jira/browse/YARN-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577861#comment-14577861
 ] 

Tsuyoshi Ozawa commented on YARN-3017:
--------------------------------------

[~zxu] [~rohithsharma] ApplicationMaster can use ContainerId.fromString() via 
ConverterUtils.toContainerId() and ContainerId.toString() e.g. MRAppMaster 
parses a string, containerIdStr, passed by an environment variable to know its 
container id. Fortunately, I think this change is compatible one since both old 
format and new format can be parsed with ContainerId.fromString().

[~mohdshahidkhan], could you update following tests to check that parsing with 
old format works fine?

TestConverterUtils.testContainerId():
{code}
    // Check to parse old format correctly.
    assertEquals(
        ConverterUtils.toContainerId("container_0_0000_00_000000"), id);
{code}

TestConverterUtils.testContainerIdWithEpoch():
{code}
    // Check to parse old format correctly.
    String id4 = "container_0_0000_000000_25645811";
    ContainerId gen4 = ConverterUtils.toContainerId(cid);
    assertEquals(gen4.toString(), id4.toString());
{code}

> ContainerID in ResourceManager Log Has Slightly Different Format From 
> AppAttemptID
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-3017
>                 URL: https://issues.apache.org/jira/browse/YARN-3017
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.8.0
>            Reporter: MUFEED USMAN
>            Priority: Minor
>              Labels: PatchAvailable
>         Attachments: YARN-3017.patch, YARN-3017_1.patch, YARN-3017_2.patch
>
>
> Not sure if this should be filed as a bug or not.
> In the ResourceManager log in the events surrounding the creation of a new
> application attempt,
> ...
> ...
> 2014-11-14 17:45:37,258 INFO
> org.apache.hadoop.yarn.server.resourcemanager.amlauncher.AMLauncher: Launching
> masterappattempt_1412150883650_0001_000002
> ...
> ...
> The application attempt has the ID format "_1412150883650_0001_000002".
> Whereas the associated ContainerID goes by "_1412150883650_0001_02_".
> ...
> ...
> 2014-11-14 17:45:37,260 INFO
> org.apache.hadoop.yarn.server.resourcemanager.amlauncher.AMLauncher: Setting 
> up
> container Container: [ContainerId: container_1412150883650_0001_02_000001,
> NodeId: n67:55933, NodeHttpAddress: n67:8042, Resource: <memory:2048, 
> vCores:1,
> disks:0.0>, Priority: 0, Token: Token { kind: ContainerToken, service:
> 10.10.70.67:55933 }, ] for AM appattempt_1412150883650_0001_000002
> ...
> ...
> Curious to know if this is kept like that for a reason. If not while using
> filtering tools to, say, grep events surrounding a specific attempt by the
> numeric ID part information may slip out during troubleshooting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to