[ 
https://issues.apache.org/jira/browse/YARN-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586377#comment-14586377
 ] 

Xuan Gong commented on YARN-3714:
---------------------------------

bq. HAUtil.verifyAndSetConfiguration works only on the RM node. AMs running in 
slave nodes also need to know the RM webapp addresses.

Thanks for the explanation. That makes sense.

The patch looks good overall. One small nit:
in {code}
  public static List<String> getRMHAWebappAddresses(
      final YarnConfiguration conf) {
{code}
We could check whether RM_WEBAPP_ADDRESS has been set with RM-ids. If not, we 
only need to check whether RM_HOSTNAME has been set with RM-ids instead of 
calling {code}
HAUtil.verifyAndSetRMHAIdsList(conf);
{code} ?

> AM proxy filter can not get proper default proxy address if RM-HA is enabled
> ----------------------------------------------------------------------------
>
>                 Key: YARN-3714
>                 URL: https://issues.apache.org/jira/browse/YARN-3714
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Masatake Iwasaki
>            Assignee: Masatake Iwasaki
>            Priority: Minor
>         Attachments: YARN-3714.001.patch, YARN-3714.002.patch, 
> YARN-3714.003.patch
>
>
> Default proxy address could not be got without setting 
> {{yarn.resourcemanager.webapp.address._rm-id_}} and/or 
> {{yarn.resourcemanager.webapp.https.address._rm-id_}} explicitly if RM-HA is 
> enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to