[ 
https://issues.apache.org/jira/browse/YARN-3802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586507#comment-14586507
 ] 

Xuan Gong commented on YARN-3802:
---------------------------------

[~zxu] The patch looks good overall. One nit:
Could you fix the comment, too ?
{code}
             // Only add new node if old state is RUNNING
{code}

> Two RMNodes for the same NodeId are used in RM sometimes after NM is 
> reconnected.
> ---------------------------------------------------------------------------------
>
>                 Key: YARN-3802
>                 URL: https://issues.apache.org/jira/browse/YARN-3802
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.7.0
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: YARN-3802.000.patch
>
>
> Two RMNodes for the same NodeId are used in RM sometimes after NM is 
> reconnected. Scheduler and RMContext use different RMNode reference for the 
> same NodeId sometimes after NM is reconnected, which is not correct. 
> Scheduler and RMContext should always use same RMNode reference for the same 
> NodeId.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to