[ 
https://issues.apache.org/jira/browse/YARN-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589287#comment-14589287
 ] 

Zhijie Shen commented on YARN-3706:
-----------------------------------

I didn't check the patch details, but according to this code refactor work, I 
suggest moving EntityXXXX, the entity table related classes, to 
{{org/apache/hadoop/yarn/server/timelineservice/storage/entity}}. Thoughts?

> Generalize native HBase writer for additional tables
> ----------------------------------------------------
>
>                 Key: YARN-3706
>                 URL: https://issues.apache.org/jira/browse/YARN-3706
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Joep Rottinghuis
>            Assignee: Joep Rottinghuis
>            Priority: Minor
>         Attachments: YARN-3706-YARN-2928.001.patch, 
> YARN-3706-YARN-2928.010.patch, YARN-3706-YARN-2928.011.patch, 
> YARN-3706-YARN-2928.012.patch, YARN-3706-YARN-2928.013.patch, 
> YARN-3706-YARN-2928.014.patch, YARN-3726-YARN-2928.002.patch, 
> YARN-3726-YARN-2928.003.patch, YARN-3726-YARN-2928.004.patch, 
> YARN-3726-YARN-2928.005.patch, YARN-3726-YARN-2928.006.patch, 
> YARN-3726-YARN-2928.007.patch, YARN-3726-YARN-2928.008.patch, 
> YARN-3726-YARN-2928.009.patch
>
>
> When reviewing YARN-3411 we noticed that we could change the class hierarchy 
> a little in order to accommodate additional tables easily.
> In order to get ready for benchmark testing we left the original layout in 
> place, as performance would not be impacted by the code hierarchy.
> Here is a separate jira to address the hierarchy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to