[ 
https://issues.apache.org/jira/browse/YARN-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592122#comment-14592122
 ] 

Sidharta Seethana commented on YARN-2194:
-----------------------------------------

[~ywskycn] ,  I see the following in the patch :

{code}
+++ 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/privileged/PrivilegedOperationExecutor.java
@@ -30,6 +30,7 @@
 import org.apache.hadoop.util.Shell.ExitCodeException;
 import org.apache.hadoop.yarn.api.ApplicationConstants;
 import org.apache.hadoop.yarn.conf.YarnConfiguration;
+import org.apache.hadoop.yarn.server.nodemanager.LinuxContainerExecutor;
{code}

Please note that {{LinuxContainerExecutor}} already has a dependency on 
{{PrivilegedOperation}} and indirectly on {{PrivilegedOperationExecutor}} ( via 
resource handlers ). It doesn't make sense to add a dependency on 
{{LinuxContainerExecutor}} here - it makes it a circular dependency of sorts. 
{{PrivilegedOperationExecutor}} is a wrapper around the container-executor 
binary and the idea is move all invocations of container-executor to use this 
mechanism.  I recommend instead adding this constant in {{PrivilegedOperation}} 
or {{PrivilegedOperationExecutor}} as mentioned before. 


> Cgroups cease to work in RHEL7
> ------------------------------
>
>                 Key: YARN-2194
>                 URL: https://issues.apache.org/jira/browse/YARN-2194
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.7.0
>            Reporter: Wei Yan
>            Assignee: Wei Yan
>            Priority: Critical
>         Attachments: YARN-2194-1.patch, YARN-2194-2.patch, YARN-2194-3.patch, 
> YARN-2194-4.patch, YARN-2194-5.patch
>
>
> In RHEL7, the CPU controller is named "cpu,cpuacct". The comma in the 
> controller name leads to container launch failure. 
> RHEL7 deprecates libcgroup and recommends the user of systemd. However, 
> systemd has certain shortcomings as identified in this JIRA (see comments). 
> This JIRA only fixes the failure, and doesn't try to use systemd.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to