[ https://issues.apache.org/jira/browse/YARN-2801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593748#comment-14593748 ]
Naganarasimha G R commented on YARN-2801: ----------------------------------------- Hi [~leftnoteasy] Had a few points from my side (many are cosmetic than technical, you can check whether they are required as its my view) # Regarding Exclusive and Non-exclusive, could it be more explicit/better word it as, Exclusive Partition doesnt share the resources with containers which is not requesting for the same partition(label). and Non Exclusive shares the resources with containers which are requesting for Default partition also . # As per YARN-2498, when we need to preempt containers from a queue's partition, we will first preempt ignore_partition_exclusivity allocated containers. this needs to be captured in the doc, And (not related to this jira)also would it be good to provide an option to not allocate containers in non exclusive partition as the containers can get preempted ? # Concept of Default Partition needs to be explained (if no labels are assigned then it belongs to default partition or something ... and requests which are not specifying any label will be given for Default Partition). "Default_Partition" is used in the Web page hence better captured in the doc too # ??one application can only use subset of node labels can be accessed by the queue which contains the application?? => {{one application can only use subset of node labels *that* can be accessed by the queue which contains the application}} # ??You can specify which node partition is need when allocating container or submiting application?? => {{You can specify which node partition is *needed* when allocating container or submiting application.}} or just {{You can specify required node partition when allocating container or submiting application.}} # ??Percentage of each queue can access resource with each label?? => {{Specify percentage of resource of a partition which can be accessed by a queue}} # ??You can specify?? can it be {{user can specify}}, i feel using of "I" and "you" in documentation would not be good # ??Specify node label requirement in Resource request,?? => {{Specify required Node Label in Resource request}} # ??Update node labels - user/admin can update labels?? => i think only admin can update using yarn rmadmin command # value mentioned for {{yarn.node-labels.fs-store.root-dir & yarn.node-labels.enabled}} looks like the default value which i think is not ? so may be as in other Property tables better to describe about the property and the default value. Also would it be better to specfiy that local file system can also be configured ? # ??yarn rmadmin -addToClusterNodeLabels label_1(exclusive=true/false),label_2(exclusive=true/false)?? => {{yarn rmadmin -addToClusterNodeLabels *"* label_1(exclusive=true/false),label_2(exclusive=true/false) *"*}} # ??When there’re labels on some nodes in the cluster, this means percentage of resources on nodes without label.?? dint get the meaning of this sentence # ??If you want to explicitly specify a queue can only access nodes without labels, just put a space as the value.?? even blank or no configuration has the same effect right ? # ??Set the percentage of the queue can access to nodes with <label>.?? => {{Set the percentage of resource of a label which can be accessed by a queue}} # {{maximum-capacity}} default value is 100 right ? & default for {{capacity}} is 0 ? # ??Value like “hbase”, which means: if applications submitted to the queue without specifying node label in their resource requests, it will use the default-node-label-expression?? => better place the end part as {{it will use "hbase" as default-node-label-expression.}} # ??(I used key=value here for readability)?? => {{(key=value is used here for readability))}} and in the example total capacity of all children queues @ root is 99 # No mention about the Node Label UI or about the REST API for Node Labels ? RESt would be better captured in another page . thoughts ? # Would it be better to give a link in CS web doc page mentioning that Node Labels scheduler Configuration can be referred to this node labels doc's section ? > Documentation development for Node labels requirment > ---------------------------------------------------- > > Key: YARN-2801 > URL: https://issues.apache.org/jira/browse/YARN-2801 > Project: Hadoop YARN > Issue Type: Sub-task > Components: documentation > Reporter: Gururaj Shetty > Assignee: Wangda Tan > Attachments: YARN-2801.1.patch > > > Documentation needs to be developed for the node label requirements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)