Vinod Kumar Vavilapalli commented on YARN-3811:

bq.  For NM work-preserving restart, I found the code already make sure 
everything starts first before starting the containerManager server.
I didn't realize this, tx for pointing out.

Had an offline discussion with [~jianhe] and couldn't come up with a case where 
not blocking the calls will be a problem. In all the cases, whether the calls 
are blocked or not, eventually they will be rejected for invalid-token-error or 
container-given-by-old-RM. Even if the calls are not blocked, the same errors 
happen right-away.

I am +1 now for not throwing this exception from the NM side. But given that it 
is part of the contract, I don't think we should remove the class in case.

> NM restarts could lead to app failures
> --------------------------------------
>                 Key: YARN-3811
>                 URL: https://issues.apache.org/jira/browse/YARN-3811
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.7.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Critical
> Consider the following scenario:
> 1. RM assigns a container on node N to an app A.
> 2. Node N is restarted
> 3. A tries to launch container on node N.
> 3 could lead to an NMNotYetReadyException depending on whether NM N has 
> registered with the RM. In MR, this is considered a task attempt failure. A 
> few of these could lead to a task/job failure.

This message was sent by Atlassian JIRA

Reply via email to