[ 
https://issues.apache.org/jira/browse/YARN-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598710#comment-14598710
 ] 

Xuan Gong commented on YARN-221:
--------------------------------

I think that we could have this configuration
{code}
<property>
    <name>yarn.container-log-aggregation-policy.class</name>
    
<value>org.apache.hadoop.yarn.container-log-aggregation-policy.SampleRateContainerLogAggregationPolicy</value>
</property>
{code}
which can be used as default log-aggregation-policy. If the users do not 
specify the policy class in ASC, the default policy will be used

But maybe we do not need this one to specify the policy parameters:
{code}
<property>
    
<name>yarn.container-log-aggregation-policy.class.SampleRateContainerLogAggregationPolicy</name>
    <value>SR:0.2</value>
</property>
{code}
Instead, we could set the default value for the policy. 

Also, in AppLogAggregator.java (From NM), after we parse the policy from ASC, 
we should do 
ContainerLogAggregationPolicy.parseParamter(ASC.logAggregationContext.getParamters()).

Others are fine to me.

> NM should provide a way for AM to tell it not to aggregate logs.
> ----------------------------------------------------------------
>
>                 Key: YARN-221
>                 URL: https://issues.apache.org/jira/browse/YARN-221
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: log-aggregation, nodemanager
>            Reporter: Robert Joseph Evans
>            Assignee: Ming Ma
>         Attachments: YARN-221-trunk-v1.patch, YARN-221-trunk-v2.patch, 
> YARN-221-trunk-v3.patch, YARN-221-trunk-v4.patch, YARN-221-trunk-v5.patch
>
>
> The NodeManager should provide a way for an AM to tell it that either the 
> logs should not be aggregated, that they should be aggregated with a high 
> priority, or that they should be aggregated but with a lower priority.  The 
> AM should be able to do this in the ContainerLaunch context to provide a 
> default value, but should also be able to update the value when the container 
> is released.
> This would allow for the NM to not aggregate logs in some cases, and avoid 
> connection to the NN at all.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to