[
https://issues.apache.org/jira/browse/YARN-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601538#comment-14601538
]
Hadoop QA commented on YARN-3830:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 58s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 34s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 34s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 45s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 24s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 50m 49s | Tests passed in
hadoop-yarn-server-resourcemanager. |
| | | 88m 36s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12741871/YARN-3830_3.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / bc43390 |
| hadoop-yarn-server-resourcemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8347/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8347/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8347/console |
This message was automatically generated.
> AbstractYarnScheduler.createReleaseCache may try to clean a null attempt
> ------------------------------------------------------------------------
>
> Key: YARN-3830
> URL: https://issues.apache.org/jira/browse/YARN-3830
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: nijel
> Assignee: nijel
> Attachments: YARN-3830_1.patch, YARN-3830_2.patch, YARN-3830_3.patch
>
>
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.AbstractYarnScheduler.createReleaseCache()
> {code}
> protected void createReleaseCache() {
> // Cleanup the cache after nm expire interval.
> new Timer().schedule(new TimerTask() {
> @Override
> public void run() {
> for (SchedulerApplication<T> app : applications.values()) {
> T attempt = app.getCurrentAppAttempt();
> synchronized (attempt) {
> for (ContainerId containerId : attempt.getPendingRelease()) {
> RMAuditLogger.logFailure(
> {code}
> Here the attempt can be null since the attempt is created later. So null
> pointer exception will come
> {code}
> 2015-06-19 09:29:16,195 | ERROR | Timer-3 | Thread Thread[Timer-3,5,main]
> threw an Exception. | YarnUncaughtExceptionHandler.java:68
> java.lang.NullPointerException
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.AbstractYarnScheduler$1.run(AbstractYarnScheduler.java:457)
> at java.util.TimerThread.mainLoop(Timer.java:555)
> at java.util.TimerThread.run(Timer.java:505)
> {code}
> This will skip the other applications in this run.
> Can add a null check and continue with other applications
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
