[ https://issues.apache.org/jira/browse/YARN-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602044#comment-14602044 ]
Varun Saxena commented on YARN-3850: ------------------------------------ Yes this also looks like a problem. We should not use LocalDirAllocator for ShuffleHandler. I will look for other areas where similar problem can happen and update if I find something. > Container logs can be lost if disk is full > ------------------------------------------ > > Key: YARN-3850 > URL: https://issues.apache.org/jira/browse/YARN-3850 > Project: Hadoop YARN > Issue Type: Bug > Components: log-aggregation > Affects Versions: 2.7.0 > Reporter: Varun Saxena > Assignee: Varun Saxena > Priority: Blocker > Attachments: YARN-3850.01.patch > > > *Container logs* can be lost if disk has become bad(become 90% full). > When application finishes, we upload logs after aggregation by calling > {{AppLogAggregatorImpl#uploadLogsForContainers}}. But this call in turns > checks the eligible directories on call to > {{LocalDirsHandlerService#getLogDirs}} which in case of disk full would > return nothing. So none of the container logs are aggregated and uploaded. > But on application finish, we also call > {{AppLogAggregatorImpl#doAppLogAggregationPostCleanUp()}}. This deletes the > application directory which contains container logs. This is because it calls > {{LocalDirsHandlerService#getLogDirsForCleanup}} which returns the full disks > as well. > So we are left with neither aggregated logs for the app nor the individual > container logs for the app. -- This message was sent by Atlassian JIRA (v6.3.4#6332)