Xuan Gong commented on YARN-3705:

[~iwasakims] Thanks for working on this.
Here is one issue for this patch.
If we call resetLeaderElection inside the rmadmin.transitionToStandby(), it 
will cause a infinite loop.

Basically, resetLeaderElection--> terminate and recreate zk client --> rejoin 
the leader elector --> transitionToStandby -->resetLeaderElection

Could you check this, please ?

> forcemanual transitionToStandby in RM-HA automatic-failover mode should 
> change elector state
> --------------------------------------------------------------------------------------------
>                 Key: YARN-3705
>                 URL: https://issues.apache.org/jira/browse/YARN-3705
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Masatake Iwasaki
>            Assignee: Masatake Iwasaki
>         Attachments: YARN-3705.001.patch, YARN-3705.002.patch, 
> YARN-3705.003.patch, YARN-3705.004.patch, YARN-3705.005.patch
> Executing {{rmadmin -transitionToStandby --forcemanual}} in 
> automatic-failover.enabled mode makes ResouceManager standby while keeping 
> the state of ActiveStandbyElector. It should make elector to quit and rejoin 
> in order to enable other candidates to promote, otherwise forcemanual 
> transition should not be allowed in automatic-failover mode in order to avoid 
> confusion.

This message was sent by Atlassian JIRA

Reply via email to