Naganarasimha G R commented on YARN-3045:

thanks for reviewing [~djp] & [~sjlee0], & sorry for the late response as i was 
lil held up.
thanks for confirming consolidation  [~djp], will try to get that done by next 
bq. if need separated event queue later to make sure container metrics boom
Already i have created a async dispatcher for timeline publishing if req we can 
create another dispatcher for container metrics only. this is what you meant?

bq. For corner case that NM publisher delay too long time (queue is busy) to 
publish event, it still get chance to fail (very low chance should be 
acceptable here).
Ok, will leave The lifecycle management of app collector out of this jira. may 
be we can handle them (including multiple attempt as specified [~sangjin) in 
another jira.

bq. APPLICATION_CREATED_EVENT might be seeing the race condition
Yes there seems to be another race condition but this time not with src and the 
test but within the src.
Had seen this only once earlier but was not able to get the logs now i can 
analyze further on this.

bq. I'm a bit puzzled by the hashCode override; is it necessary? 
My mistake i think its resudual code of initial version, which may be i have 
added while trying out MultiAsync dispatcher and events of one app needs to go 
to one handler.
but not required any more, will remove it.

Will take care of other [~sjlee0] comments and will try to provide the patch at 
the earliest

> [Event producers] Implement NM writing container lifecycle events to ATS
> ------------------------------------------------------------------------
>                 Key: YARN-3045
>                 URL: https://issues.apache.org/jira/browse/YARN-3045
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3045-YARN-2928.002.patch, 
> YARN-3045-YARN-2928.003.patch, YARN-3045-YARN-2928.004.patch, 
> YARN-3045.20150420-1.patch
> Per design in YARN-2928, implement NM writing container lifecycle events and 
> container system metrics to ATS.

This message was sent by Atlassian JIRA

Reply via email to