[ 
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605073#comment-14605073
 ] 

Junping Du commented on YARN-3860:
----------------------------------

Thanks [~iwasakims] for nice catching and the patch! Latest patch LGTM. 
[~zxu], thanks for review here. I think times(1) is quite useful here as the 
calling times indicate the other nodes loops into consideration. If we have 
"rm1, rm2, rm3" in config settings before, here we should get times(2). If you 
agree with it, I will go ahead to commit this patch soon.

> rmadmin -transitionToActive should check the state of non-target node
> ---------------------------------------------------------------------
>
>                 Key: YARN-3860
>                 URL: https://issues.apache.org/jira/browse/YARN-3860
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Masatake Iwasaki
>            Assignee: Masatake Iwasaki
>            Priority: Minor
>         Attachments: YARN-3860.001.patch, YARN-3860.002.patch, 
> YARN-3860.003.patch
>
>
> Users can make both ResouceManagers active by {{rmadmin -transitionToActive}} 
> even if {{\--forceactive}} option is not given. {{haadmin 
> -transitionToActive}} of HDFS checks whether non-target nodes are already 
> active but {{rmadmin -transitionToActive}} does not do.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to