[ 
https://issues.apache.org/jira/browse/YARN-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608529#comment-14608529
 ] 

Hudson commented on YARN-3770:
------------------------------

SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2190 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2190/])
YARN-3770. SerializedException should also handle java.lang.Error on 
de-serialization. Contributed by Lavkesh Lahngir (jianhe: rev 
4672315e2d6abe1cee0210cf7d3e8ab114ba933c)
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/records/impl/pb/TestSerializedExceptionPBImpl.java
* hadoop-yarn-project/CHANGES.txt
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/SerializedExceptionPBImpl.java


> SerializedException should also handle java.lang.Error 
> -------------------------------------------------------
>
>                 Key: YARN-3770
>                 URL: https://issues.apache.org/jira/browse/YARN-3770
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Lavkesh Lahngir
>            Assignee: Lavkesh Lahngir
>             Fix For: 2.8.0
>
>         Attachments: YARN-3770.1.patch, YARN-3770.patch
>
>
> IN SerializedExceptionPBImpl deserialize() method
> {code}
>     Class classType = null;
>     if (YarnException.class.isAssignableFrom(realClass)) {
>       classType = YarnException.class;
>     } else if (IOException.class.isAssignableFrom(realClass)) {
>       classType = IOException.class;
>     } else if (RuntimeException.class.isAssignableFrom(realClass)) {
>       classType = RuntimeException.class;
>     } else {
>       classType = Exception.class;
>     }
>     return instantiateException(realClass.asSubclass(classType), getMessage(),
>       cause == null ? null : cause.deSerialize());
>   }
> {code}
> if realClass is a subclass of java.lang.Error deSerialize() throws 
> ClassCastException.
> in the last else statement classType should be equal to Trowable.class 
> instead of Exception.class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to