[ 
https://issues.apache.org/jira/browse/YARN-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sunil G updated YARN-2003:
--------------------------
    Attachment: 0018-YARN-2003.patch

Thank you [~jianhe] for sharing the comments. I am uploading a patch addressing 
this, few inlined comments.
- bq.move all the checks in one place, rather than spreading across multiple 
places.
Yes. We can move all the check in one place which will handle the ACLs 
synchronously. As mentioned earlier, I will be filing a ticket for priority 
ACLs and I will cover this point in that one.

- bq.below code is quite confusing to me - if priority is less than 
maxPriority, throw exception;
Yes. I added a new api in Priority called isGreaterThan, this can help here.

- bq.RMAppManager#createAndPopulateNewRMApp : if user doesn’t have access to 
the default app priority acl, it’ll be ignored.
Earlier idea was to have a default priority to those apps which are submitted 
w/o any priority. Hence we could define the behavior of apps in a queue 
correctly. Also we need priority ACLs, as we have to restrict when all users 
are using the highest priority always. Hence if user configures a priority ACL 
for queue's default priority, it will violate the first point (some apps can 
run w/o priority). Could we make apps to take default priority w/o seeing ACL, 
such as an exception case. Could you please pool in your thoughts.

> Support for Application priority : Changes in RM and Capacity Scheduler
> -----------------------------------------------------------------------
>
>                 Key: YARN-2003
>                 URL: https://issues.apache.org/jira/browse/YARN-2003
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Sunil G
>            Assignee: Sunil G
>              Labels: BB2015-05-TBR
>         Attachments: 0001-YARN-2003.patch, 00010-YARN-2003.patch, 
> 0002-YARN-2003.patch, 0003-YARN-2003.patch, 0004-YARN-2003.patch, 
> 0005-YARN-2003.patch, 0006-YARN-2003.patch, 0007-YARN-2003.patch, 
> 0008-YARN-2003.patch, 0009-YARN-2003.patch, 0011-YARN-2003.patch, 
> 0012-YARN-2003.patch, 0013-YARN-2003.patch, 0014-YARN-2003.patch, 
> 0015-YARN-2003.patch, 0016-YARN-2003.patch, 0017-YARN-2003.patch, 
> 0018-YARN-2003.patch
>
>
> AppAttemptAddedSchedulerEvent should be able to receive the Job Priority from 
> Submission Context and store.
> Later this can be used by Scheduler.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to