[
https://issues.apache.org/jira/browse/YARN-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619564#comment-14619564
]
Zhijie Shen commented on YARN-3116:
-----------------------------------
Xuan, thanks for your comment. I think this is a good point. To be forward
compatible, it's better to use the enum here instead of the boolean flag. In
this case, we can add more enum, such as SystemContainer and so on in the
future without adding new flag and breaking the compatibility.
[~giovanni.fumarola], [~subru], how do you think?
> [Collector wireup] We need an assured way to determine if a container is an
> AM container on NM
> ----------------------------------------------------------------------------------------------
>
> Key: YARN-3116
> URL: https://issues.apache.org/jira/browse/YARN-3116
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, timelineserver
> Reporter: Zhijie Shen
> Assignee: Giovanni Matteo Fumarola
> Attachments: YARN-3116.patch, YARN-3116.v2.patch, YARN-3116.v3.patch,
> YARN-3116.v4.patch, YARN-3116.v5.patch, YARN-3116.v6.patch, YARN-3116.v7.patch
>
>
> In YARN-3030, to start the per-app aggregator only for a started AM
> container, we need to determine if the container is an AM container or not
> from the context in NM (we can do it on RM). This information is missing,
> such that we worked around to considered the container with ID "xxxx_01" as
> the AM container. Unfortunately, this is neither necessary or sufficient
> condition. We need to have a way to determine if a container is an AM
> container on NM. We can add flag to the container object or create an API to
> do the judgement. Perhaps the distributed AM information may also be useful
> to YARN-2877.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
