[
https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-3836:
------------------------
Attachment: YARN-3836-YARN-2928.003.patch
Thanks [~sjlee0] for the review! I addressed your comments in the v3 patch,
except one point:
bq. l.550: It sounds like now the type takes precedence over the created time
in the sort order in this version. Is this intended? If not (timestamp is
supposed to be first), it might be a good idea to have Identifier implement
Comparable as well and use that in TimelineEntity.compareTo()
I think in the v1 patch we used the same approach. Giving types higher priority
was our intention in timeline v1, and I kept the same behavior here. I think in
general we would like to "group" the timeline entities first, then sort them by
time stamps? (Still, users can also pass in a simple comparator to just sort in
timestamps. )
> add equals and hashCode to TimelineEntity and other classes in the data model
> -----------------------------------------------------------------------------
>
> Key: YARN-3836
> URL: https://issues.apache.org/jira/browse/YARN-3836
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Sangjin Lee
> Assignee: Li Lu
> Attachments: YARN-3836-YARN-2928.001.patch,
> YARN-3836-YARN-2928.002.patch, YARN-3836-YARN-2928.003.patch
>
>
> Classes in the data model API (e.g. {{TimelineEntity}},
> {{TimelineEntity.Identifer}}, etc.) do not override {{equals()}} or
> {{hashCode()}}. This can cause problems when these objects are used in a
> collection such as a {{HashSet}}. We should implement these methods wherever
> appropriate.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
