[ 
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vrushali C updated YARN-3908:
-----------------------------
    Attachment: YARN-3908-YARN-2928.001.patch

Hi [~zjshen], [~sjlee0],
I have put together a quick patch tonight that perhaps [~sjlee0] can improve 
upon. 
I have addressed Zhijie's points and accordingly added the code to store the 
info map from the TimelineEvent and timestamp of the TimelineEvent. The 
timestamp will get stored as the hbase cell timestamp. If the TimelineEvent has 
a null value for the timestamp, the code picks the current timestamp.

I have also added unit tests to check for correctness of writing and reading 
these additions.

There is a TODO in the junit test for the reader side (not really for the 
writer, so in that sense we could have a separate jira to add that in or we 
could add it in with this patch). Just like there is a
EntityColumnPrefix#readResults to read a map and a 
EntityColumnPrefix#readTimeseriesResults to read the timeseries data, we need 
to have a EntityColumnPrefix#readResults api that can read TimelineEvent data. 
For now, I have added some code in the unit test itself, it needs to be 
refactored to be moved into the right place in EntityColumnPrefix.

Hope this helps [~sjlee0] to take this forward as needed while I am OOO.

thanks
Vrushali


> Bugs in HBaseTimelineWriterImpl
> -------------------------------
>
>                 Key: YARN-3908
>                 URL: https://issues.apache.org/jira/browse/YARN-3908
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Vrushali C
>         Attachments: YARN-3908-YARN-2928.001.patch
>
>
> 1. In HBaseTimelineWriterImpl, the info column family contains the basic 
> fields of a timeline entity plus events. However, entity#info map is not 
> stored at all.
> 2 event#timestamp is also not persisted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to