[
https://issues.apache.org/jira/browse/YARN-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621925#comment-14621925
]
zhihai xu commented on YARN-3857:
---------------------------------
thanks for updating the patch quickly.
The new patch looks good in general. It'd be nice to address a few small nits,
mostly regarding the comment and style.
# Change {{// this is to test master key is saved in the state store}} to {{//
this is to test master key is saved in the secret manager}}
# Remove comment {{//assumeTrue(!isSecurityEnabled);}}
# Change {{if(isSecurityEnabled)}} to {{if (isSecurityEnabled)}}
# Could you fix the indentation? It should be indented by 2(new paragraph) or 4
bytes.
+1 non-binding once these are addressed. Thanks again for working on this.
> Memory leak in ResourceManager with SIMPLE mode
> -----------------------------------------------
>
> Key: YARN-3857
> URL: https://issues.apache.org/jira/browse/YARN-3857
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 2.7.0
> Reporter: mujunchao
> Assignee: mujunchao
> Priority: Critical
> Attachments: YARN-3857-1.patch, YARN-3857-2.patch,
> hadoop-yarn-server-resourcemanager.patch
>
>
> We register the ClientTokenMasterKey to avoid client may hold an invalid
> ClientToken after RM restarts. In SIMPLE mode, we register
> Pair<ApplicationAttemptId, null> , But we never remove it from HashMap, as
> unregister only runing while in Security mode, so memory leak coming.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
