[
https://issues.apache.org/jira/browse/YARN-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624255#comment-14624255
]
Akira AJISAKA commented on YARN-3381:
-------------------------------------
Thank you for updating the patch. I have 2 comments.
{code}
+/**
+ * Hook for InvalidTransition States.
+ *
+ */
{code}
1. There are no state for {{InvalidTransition}} and this class is not a hook
but a exception. I'm thinking it's better to write as follows:
{code}
/** The exception that happens when you call invalid state transition. */
{code}
2. When you deprecate a class, you need to write a javadoc to specify the new
class as follows:
{code}
/** @deprecated Use {@link InvalidStateTransitionException} instead. */
{code}
> A typographical error in "InvalidStateTransitonException"
> ---------------------------------------------------------
>
> Key: YARN-3381
> URL: https://issues.apache.org/jira/browse/YARN-3381
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: api
> Affects Versions: 2.6.0
> Reporter: Xiaoshuang LU
> Assignee: Brahma Reddy Battula
> Labels: BB2015-05-TBR
> Attachments: YARN-3381-002.patch, YARN-3381-003.patch,
> YARN-3381-004-branch-2.patch, YARN-3381-004.patch, YARN-3381-005.patch,
> YARN-3381-006.patch, YARN-3381-007.patch, YARN-3381-008.patch,
> YARN-3381-010.patch, YARN-3381.patch
>
>
> Appears that "InvalidStateTransitonException" should be
> "InvalidStateTransitionException". Transition was misspelled.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
