Jian He commented on YARN-3916:

Won't draining events on serviceStop have the same problem ? 

Actually wondered why that flag was added in the first place, this should be 
the reason.
I think we can revert the change of YARN-3878 and fix the problem of YARN-3878 
properly ?

> DrainDispatcher#await should wait till event has been completely handled
> ------------------------------------------------------------------------
>                 Key: YARN-3916
>                 URL: https://issues.apache.org/jira/browse/YARN-3916
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>            Priority: Critical
>         Attachments: YARN-3916.01.patch, YARN-3916.02.patch
> DrainDispatcher#await should wait till event has been completely handled.
> Currently it only checks for whether event queue has become empty.
> And in many tests we directly check for a state to be changed after calling 
> await.
> Sometimes, the states do not change by the time we check them as event has 
> not been completely handled.
> *This is causing test failures* such as YARN-3909 and YARN-3910 and may cause 
> other test failures as well.

This message was sent by Atlassian JIRA

Reply via email to