Jian He commented on YARN-1449:

bq. because it may need to create the this.containersToIncrease if it is null.
If this.containersToIncrease is null, wont this call return upfront  ?
if (containersToIncrease == null) {
bq. The AllocateRequestPBImpl.setAskList() uses the same logic.
Actually, many places use this logic. No need to respect that. The PB 
implementations are often past-and-copy code that people pay less attention to 

> AM-NM protocol changes to support container resizing
> ----------------------------------------------------
>                 Key: YARN-1449
>                 URL: https://issues.apache.org/jira/browse/YARN-1449
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api
>            Reporter: Wangda Tan (No longer used)
>            Assignee: MENG DING
>         Attachments: YARN-1449.1.patch, YARN-1449.2.patch, YARN-1449.3.patch, 
> yarn-1449.1.patch, yarn-1449.3.patch, yarn-1449.4.patch, yarn-1449.5.patch
> AM-NM protocol changes to support container resizing
> 1) "IncreaseContainersResourceRequest" and 
> "IncreaseContainersResourceResponse" PB protocol and implementation
> 2) "increaseContainersResources" method in ContainerManagementProtocol
> 3) Update "ContainerStatus" protocol to include Resource
> 4) Relevant test cases

This message was sent by Atlassian JIRA

Reply via email to