[ 
https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625513#comment-14625513
 ] 

MENG DING commented on YARN-3866:
---------------------------------

* The FindBugs doesn't seem to be working in YARN-1197 branch (My own tests 
work fine though)

* The checkstyle issues are false alarms. They are needed for Javadocs to work

{code:title=ContainerResourceChangeRequest.java|borderStyle=solid}
+import org.apache.hadoop.classification.InterfaceAudience.Public;
+import org.apache.hadoop.classification.InterfaceStability.Unstable;
+import org.apache.hadoop.yarn.api.ApplicationMasterProtocol;    <----------- 
(Needed for Javadoc related method)
+import org.apache.hadoop.yarn.util.Records;
+
+/**
+ * {@code ContainerResourceChangeRequest} represents the request made by an
+ * application to the {@code ResourceManager} to change resource allocation of
+ * a running {@code Container}.
+ * <p>
+ * It includes:
+ * <ul>
+ *   <li>{@link ContainerId} for the container.</li>
+ *   <li>
+ *     {@link Resource} capability of the container after the resource change
+ *     is completed.
+ *   </li>
+ * </ul>
+ *
+ * @see 
ApplicationMasterProtocol#allocate(org.apache.hadoop.yarn.api.protocolrecords.AllocateRequest)
    <-------- (can't break this otherwise Javadoc won't work.)
+ */
{code}

> AM-RM protocol changes to support container resizing
> ----------------------------------------------------
>
>                 Key: YARN-3866
>                 URL: https://issues.apache.org/jira/browse/YARN-3866
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api
>            Reporter: MENG DING
>            Assignee: MENG DING
>         Attachments: YARN-3866-YARN-1197.4.patch, YARN-3866.1.patch, 
> YARN-3866.2.patch, YARN-3866.3.patch
>
>
> YARN-1447 and YARN-1448 are outdated. 
> This ticket deals with AM-RM Protocol changes to support container resize 
> according to the latest design in YARN-1197.
> 1) Add increase/decrease requests in AllocateRequest
> 2) Get approved increase/decrease requests from RM in AllocateResponse
> 3) Add relevant test cases



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to